-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Add sorting icon if the column is sorted #4343
[EuiDataGrid] Add sorting icon if the column is sorted #4343
Conversation
I have used the |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a minor PR to adjust some spacing. This is a nice PR with the appropriate tests.
I tested it extensively in browser in a couple scenarios. The truncation still works as I'd expect when the column is collapsed.
Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 from Discover side!
Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/ |
@stratoula Don't forget a changelog before you merge this. |
@snide thank you, I def missed that 🙂 |
This comment has been minimized.
This comment has been minimized.
@stratoula disregard my last comment. Apparently it's more of a contentious change than I thought 😆 |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/ |
OK. @cchaos and I discussed. This is safe to merge as-is (upon @chandlerprall approval). We'll revisit the sorting arrows more generically in EUI (since tables use them) in a later PR. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM; tested various configurations in the PR's published docs.
Thanks for the test coverage!
Summary
It adds a sorting indicator on the EuiDataGridColumn which renders only when the column is sorted and indicates the sorting direction.
Checklist