Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icons] Adding fold and unfold glyphs to EuiIcon #3994

Merged
merged 7 commits into from
Sep 2, 2020
Merged

[Icons] Adding fold and unfold glyphs to EuiIcon #3994

merged 7 commits into from
Sep 2, 2020

Conversation

formgeist
Copy link
Contributor

Summary

To be used in the APM trace timeline to multi-collapse or expand accordions used in the visualization.

Kapture 2020-09-01 at 16 07 46

Screenshot 2020-09-02 at 13 58 21 Screenshot 2020-09-02 at 13 58 28
Screenshot 2020-09-02 at 13 48 42 Screenshot 2020-09-02 at 13 48 48

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@formgeist
[Icons] Adding ‘fold’ and ‘unfold’ glyphs
647b62e 
To be used in the APM timeline trace for folding and unfolding entire traces (multiple accordions).
@formgeist
Updated snapshot
706ccfc
@formgeist
Update fold.svg
bb4c5c4
@formgeist
Updating icons
dae0627
@formgeist
Updated snapshots
cd8a545
@formgeist formgeist added the icons label Sep 2, 2020
@formgeist formgeist self-assigned this Sep 2, 2020
@formgeist
Copy link
Contributor Author

formgeist commented Sep 2, 2020 •
edited
Loading

@cchaos These are the replacement glyphs for the previously suggested rowsCollapse and rowsExpand PR (#3905)

@formgeist formgeist mentioned this pull request Sep 2, 2020
Closed
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3994/

@formgeist formgeist mentioned this pull request Sep 2, 2020
Closed
cchaos
cchaos approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I saw your pixel artboard in slack and looked tidy there. Names work for me. 🎉

@formgeist formgeist merged commit 9d780c2 into elastic:master Sep 2, 2020
@formgeist formgeist deleted the icon-fold-unfold-set branch September 2, 2020 14:16
@thompsongl thompsongl mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees

@formgeist formgeist

Labels
icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@formgeist @kibanamachine @cchaos