[WIP][TEST] Repl all physical-to-logical units #3992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3992/ |
nyurik
force-pushed
the
nyurik/all-rtl
branch
from
b06b4fd
to
f1909b0
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3992/ |
nyurik
force-pushed
the
nyurik/all-rtl
branch
from
f1909b0
to
913c2cc
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3992/ |
** DO NOT MERGE ** This is a test to see and discuss how EUI Docs will appear if all margin, padding, and borders are replaced with the logical units rather than the physical ones. Example: `margin-left` -> `margin-inline-start`. The replacements were done with a script https://gist.github.com/nyurik/d438cb56a9059a0660ce4176ef94576f
nyurik
force-pushed
the
nyurik/all-rtl
branch
from
913c2cc
to
753f499
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3992/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3992/ |
|
Hey @nyurik ! Thanks again for showing us how we can eventually support RTL languages better. I'm going to close this PR as it's much out of date, but it'll obviously still be around for reference. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** DO NOT MERGE **
This is a test to see and discuss how EUI Docs will appear if all margin, padding, and borders are replaced with the logical units rather than the physical ones. Example:
margin-left->margin-inline-start.The replacements were done with a script
https://gist.github.com/nyurik/d438cb56a9059a0660ce4176ef94576f
Summary
Provide a detailed summary of your PR. Explain how you arrived at your solution. If it includes changes to UI elements include a screenshot or gif.
Checklist