Use more complete implementation of Omit in TypeScript definitions #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types in EuiContextMenu caused errors that seemed to result from usage of the `Omit<>` helper. It might be fixed with microsoft/TypeScript#21148, which is expected to be included in 2.7.1.
cjcenizal
reviewed
Jan 19, 2018
There was a problem hiding this comment.
@weltenwort Would you like a real review or were you just pinging me so I'm aware of this? If the former then I'll need some hand-holding because I have a toddler's understanding of TS.
|
I guess it was more for awareness. I just didn't know whom else to tag, who is familiar with the inner workings of EUI. How do we want to handle upcoming TS PRs? |
|
Let's set up a sharing session next week. We can help and I obviously need
to learn now that I'm mucking around in logging. Then hopefully we can help
maintain it a bit.
…On Jan 19, 2018 7:19 AM, "Felix Stürmer" ***@***.***> wrote:
I guess it was more for awareness. I just didn't know whom else to tag,
who is familiar with the inner workings of EUI. How do we want to handle
upcoming TS PRs?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#322 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AATzp0yM1ZinA-kbIW47eBxHXdcqzGk2ks5tMLKDgaJpZM4RkZ4r>
.
|
The previous implementation of the `Omit` type did not support optional and readonly fields, which led to type errors when using the components.
weltenwort
force-pushed
the
enhancement/ts-types-2
branch
from
bfb86ab to
9b769e7
Compare
weltenwort
changed the title
|
Ok, I seem to have found the root cause: The previous implementation of |
uboness
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeScript definitions for EuiContextMenu caused errors that seemed to result from usage of the
Omit<>helper. It might be fixed with microsoft/TypeScript#21148, which is expected to be included in 2.7.1.