Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta XYChart Component #309

Merged
merged 112 commits into from
Jul 6, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
112 commits
Select commit Hold shift + click to select a range
b6ac55e
WIP chart
Jan 16, 2018
1654195
fix bug with tooltip when only one series skips data points
Jan 17, 2018
4f24d16
finish commit
Jan 17, 2018
f00be1f
update new path
Jan 17, 2018
b8dc6a5
re-add selection UI
Jan 17, 2018
9c05386
clean up select events
Jan 17, 2018
76bf6b7
fix select bar color
Jan 17, 2018
aa9b02e
add onClick to series API
Jan 17, 2018
49044be
add show axis(s) prop(s)
Jan 17, 2018
3e3591b
tweak designs
Jan 17, 2018
4732556
add axis location options
Jan 17, 2018
33ae502
color should not be a required prop
Jan 17, 2018
1e66e16
added empty state to chart
Jan 17, 2018
1b30eed
allow custom error message
Jan 17, 2018
739fd06
allow error any time
Jan 17, 2018
5390137
added chart mode
Jan 18, 2018
72e8bba
add abilaty to hide hover for tooltips
Jan 18, 2018
655ec69
auto create axis when no axis is provided
Jan 18, 2018
1630f4c
improve auto axis demo
Jan 18, 2018
6825be7
initial tests for EuiChart and EuiArea
chandlerprall May 7, 2018
ba31e1c
check in the title test snapshot
chandlerprall May 7, 2018
440ab7f
updated area chart test, added bar test
chandlerprall May 8, 2018
945195f
Added line chart test
chandlerprall May 8, 2018
0802fde
WIP chart
Jan 16, 2018
fdc1136
rename to xy_chart
May 10, 2018
f4f544a
added benchmark utils for tests, added benchmarks to EuiLine
chandlerprall May 10, 2018
58e8427
Updated EuiLine test for EuiXYChart rename
chandlerprall May 10, 2018
38cf3a5
added performance testing for EuiArea and EuiBar
chandlerprall May 11, 2018
27f77b0
perf fix and rename method, fix jumping coursor
May 15, 2018
f46c00b
code cleanup
May 16, 2018
ffff904
update snapshots
May 16, 2018
2ab6232
fix chart courser location math
May 16, 2018
8bccc5b
fixed crosshair, now shows no data, series data index length no longe…
May 16, 2018
c6b5d43
Added API for the creation of custom series components… needs docs, c…
May 16, 2018
670eac1
updating docs
May 17, 2018
19880e7
make complex example complex, micro-perf improvment
May 18, 2018
3637e14
lex complex example for readability reasons
May 18, 2018
a3b35ae
debounce mouse movement
May 21, 2018
d0a53ad
move patching/unpatching of Math.random to beforeEach and afterEach
chandlerprall May 23, 2018
e215e30
new ref api and major perf boos, skip perf tests
May 24, 2018
2033740
Support for extra props like className and aria-* on wrapping element
chandlerprall May 24, 2018
cc261f8
First version of barchart/histogram with examples
markov00 Jun 1, 2018
2dd7099
Fix wrong component naming. Fix stacked mechanism
markov00 Jun 1, 2018
f6f75ac
Update examples
markov00 Jun 1, 2018
bc0df73
Update example descriptions
markov00 Jun 1, 2018
454a430
Update props types
markov00 Jun 1, 2018
4959f23
Add DefaultAxis component
markov00 Jun 12, 2018
8de2333
Added first branch of tests for rect and bars
markov00 Jun 13, 2018
4c0d21e
Refactoring chart docs
markov00 Jun 13, 2018
fd182fe
Updated line examples descriptions
markov00 Jun 13, 2018
7fed0c3
Refactored area examples
markov00 Jun 13, 2018
e0b2baa
Fix existing charts examples
markov00 Jun 13, 2018
881af88
Add first draft of EuiAxis and EuiGrids
markov00 Jun 13, 2018
048e5ee
Update docs example groups names
markov00 Jun 13, 2018
df37f18
First version of multi axis chart
markov00 Jun 14, 2018
535a3f6
Add first draft of crosshair
markov00 Jun 15, 2018
a90a696
Refactoring exports removing default exports
markov00 Jun 15, 2018
610d0b1
Add X chrosshair with fixed histogram and series behaviours
markov00 Jun 18, 2018
53f779f
Add crosshair Y
markov00 Jun 19, 2018
facae27
Fix examples and updated the XYChart API
markov00 Jun 19, 2018
60024f3
Removed console.log
markov00 Jun 19, 2018
26974ab
Add showDefaultAxis prop on XYChart. Formatted examples
markov00 Jun 19, 2018
038c868
Add two example of time series
markov00 Jun 19, 2018
b6a0915
House-cleaning
markov00 Jun 20, 2018
c5f009a
Refactoring exporting for utils
markov00 Jun 20, 2018
d1b5d73
Revert "Refactoring exporting for utils"
markov00 Jun 20, 2018
bdcd183
Fix missing y crosshair on horizontal histogram
markov00 Jun 20, 2018
dbce45d
Fix time histogram example to be stacked
markov00 Jun 20, 2018
95b9f17
Add propTypes docs on XYChart. Add correct displayName to chart elements
markov00 Jun 20, 2018
cc93e80
Renamed highlight to brush. Add vertical, horizontal and both orienta…
markov00 Jun 20, 2018
2e47b66
Fix Axis example rotation to a useful one
markov00 Jun 21, 2018
4facfaa
Fix xType and yType propTypes
markov00 Jun 21, 2018
166df6e
Removed unused functions getTicks and getTicksLabels from default_axis
markov00 Jun 21, 2018
5008dfe
Removed unneccessary tspan for a better Fragment on tspanTextWrapper
markov00 Jun 21, 2018
f9f12d0
Removed showLine from line_series
markov00 Jun 22, 2018
1049caf
Renamed on0 to onZero props for axis components
markov00 Jun 22, 2018
235f8b0
Renamed EuiBrush to EuiSelectionBrush
markov00 Jun 22, 2018
c25e28a
Renamed prop animation to animateData in XYChart
markov00 Jun 22, 2018
e6d6e10
Renamed selection brush props on XYChart
markov00 Jun 22, 2018
6dadbb8
Fix wrong xy chart and line props on examples
markov00 Jun 22, 2018
10724d8
Add prop checking for series color
markov00 Jun 25, 2018
3b9fd04
Fix custom line example after removing showLine props from EuiLineSeries
markov00 Jun 25, 2018
c29c9e9
Add basic annotation component
markov00 Jun 25, 2018
864e43b
WIP fix mouseover behaviours on series
markov00 Jun 26, 2018
d183e4b
Add mouse pointer change on hover
markov00 Jun 26, 2018
b3c816b
Move curves to enum
markov00 Jun 26, 2018
24c1557
Update snapshots
markov00 Jun 26, 2018
48888a3
Small refactoring of EuiXYChart. Adding some tests for XYChart and De…
markov00 Jun 27, 2018
6f16da3
Add axis tests
markov00 Jun 27, 2018
155c2db
Add crosshair tests
markov00 Jun 27, 2018
04cbc0c
Add basic test for selection brush
markov00 Jun 27, 2018
cd3e044
Partial fix brush compute values on ordinal scales
markov00 Jun 27, 2018
6b909b4
Updated react-vis to 1.10.0. Moved react-vis scss to eui scss.
markov00 Jun 28, 2018
074d4fa
Extracted basic styling to scss classes
markov00 Jun 28, 2018
6ce7d75
Fix some inverted examples
markov00 Jun 28, 2018
bf0db79
Refactoring and abstracting BarSeries and HistogramSeries
markov00 Jun 29, 2018
265f0e7
Fix typo prop in XYChart
markov00 Jul 2, 2018
101db8d
Hide orientation props from bars and histograms
markov00 Jul 2, 2018
9aec73c
LineSeries default to sparkline
markov00 Jul 2, 2018
5017295
Mark as experimental horizontal charts and orientation props
markov00 Jul 2, 2018
8efb8f3
Add Range area chart example
markov00 Jul 2, 2018
c3797d0
Remove use of orientation specific BarSeries on examples
markov00 Jul 2, 2018
6e1f842
Rename tspanWrapper into labelWordWrap
markov00 Jul 2, 2018
f1fb5fe
Add colors props type
markov00 Jul 2, 2018
ca9987f
Add color type prop test
markov00 Jul 2, 2018
8d579af
Update tests with props
markov00 Jul 2, 2018
c203549
Add onValueClick props to histogram
markov00 Jul 2, 2018
fe05969
Add series names to crosshair
markov00 Jul 3, 2018
0055aed
last min version bump and add meta warnings, also linting fixes
mattapperson Jul 5, 2018
3b47859
Fix failing tests on charts after upgrading react-vis 1.10.1
markov00 Jul 5, 2018
dc0b1d0
Fix example typos
markov00 Jul 5, 2018
60da33e
Updated changelog
markov00 Jul 6, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed showLine from line_series
  • Loading branch information
markov00 committed Jul 6, 2018
commit f9f12d01c0843027ebf4b12d2366e9893da1da65
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ exports[`EuiLineSeries all props are rendered 1`] = `
sameTypeIndex={0}
sameTypeTotal={1}
seriesIndex={0}
showLine={true}
showLineMarks={true}
sizeDomain={Array []}
sizeRange={
Expand Down Expand Up @@ -2975,7 +2974,6 @@ exports[`EuiLineSeries is rendered 1`] = `
sameTypeIndex={0}
sameTypeTotal={1}
seriesIndex={0}
showLine={true}
showLineMarks={true}
sizeDomain={Array []}
sizeRange={
Expand Down
49 changes: 21 additions & 28 deletions src/components/xy_chart/series/line_series.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export class EuiLineSeries extends AbstractSeries {
curve,
onClick,
onMarkClick,
showLine,
showLineMarks,
lineSize,
lineMarkColor,
Expand All @@ -22,33 +21,29 @@ export class EuiLineSeries extends AbstractSeries {

return (
<g>
{showLine &&
<LineSeries
{...rest}
key={`${name}-border`}
curve={curve}
data={data}
opacity={1}
onSeriesClick={onClick}
style={{
<LineSeries
{...rest}
key={`${name}-border`}
curve={curve}
data={data}
opacity={1}
onSeriesClick={onClick}
style={{
strokeWidth: lineSize + 2, // border margin
}}
_colorValue={'white'}
/>
}
{showLine &&
<LineSeries
{...rest}
key={name}
curve={curve}
data={data}
opacity={1}
style={{
}}
_colorValue={'white'}
/>
<LineSeries
{...rest}
key={name}
curve={curve}
data={data}
opacity={1}
style={{
strokeWidth: lineSize,
}}
color={color}
/>
}
}}
color={color}
/>

{showLineMarks && (
<MarkSeries
Expand Down Expand Up @@ -87,7 +82,6 @@ EuiLineSeries.propTypes = {
/** Without a color set, a random EUI color palette color will be chosen */
color: PropTypes.string,
curve: PropTypes.string,
showLine: PropTypes.bool,
showLineMarks: PropTypes.bool,
lineSize: PropTypes.number,
lineMarkColor: PropTypes.string,
Expand All @@ -98,7 +92,6 @@ EuiLineSeries.propTypes = {

EuiLineSeries.defaultProps = {
curve: 'linear',
showLine: true,
showLineMarks: true,
lineSize: 2,
lineMarkSize: 5
Expand Down