-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cheer glyph to EuiIcon #2814
Conversation
😎 Nice. I pulled the icon down and put it onto a pixel grid and it looks like the icon uses several line types (some rounded caps, some not) and there are lines that could be aligned to the pixel grid but aren't. This will make them very fuzzy on non-retina screens. If you need some help adjusting the icon let us know. |
If possible, that would be great, I'm happy to zoom and go over it or if its quick and easy, and you don't mind, I'm also happy for you to clean it up. |
I'll take a stab for you. |
Thanks @cchaos looks great! |
To try to remove the carrot likeness
Talked with @gjones about it a bit more and decided to make some changes to the confetti portion to try to remove the carrot likeness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😉
Summary
Related to #2813
We're looking to add an icon that communicates an announcement, this is one that our team came up with.
Checklist
cc @kaleighflynn