-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated logo for Security, added logos for Workplace and Observability #2769
Conversation
jenkins test this #2765 strikes again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to do the same with APM / Observability as far as the new logo goes. Replace APM and deprecate, then make a new Observability one.
Sorry, I missed that in my instructions. Your code looks correct though.
cc @elastic/observability-design and @MichaelMarcialis for visibility that these changes are coming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Double checked the deprecated logos still work and spit out the new icons. Please add a deprecation note to this CL. You can see an example in the 14.0.0 release.
@snide I would have thought we'd deprecate Logging, Metrics, and Uptime too because we're adding a single Observability solution logo? |
Summary
logoWorkplaceSearch
)logoEnterpriseSearch
to use the new svg for Workplace. We'll be deprecatinglogoEnterpriseSearch
in the future as marked in [Meta] Deprecation schedule #1469logoEnterpriseSearch
from the docsRelated to #2767 and elastic/Design#2208
Checklist
- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes