Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated logo for Security, added logos for Workplace and Observability #2769

Merged
merged 5 commits into from
Jan 17, 2020

Conversation

andreadelrio
Copy link
Contributor

@andreadelrio andreadelrio commented Jan 16, 2020

Summary

  • Updated product logos for Observability and Security.
  • Added a new icon for Workplace (logoWorkplaceSearch)
  • Updated logoEnterpriseSearch to use the new svg for Workplace. We'll be deprecating logoEnterpriseSearch in the future as marked in [Meta] Deprecation schedule #1469
  • Removed logoEnterpriseSearch from the docs

image
image

Related to #2767 and elastic/Design#2208

Checklist

  • Check against all themes for compatibility in both light and dark modes
    - [ ] Checked in mobile
    - [ ] Checked in IE11 and Firefox
    - [ ] Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@snide snide self-requested a review January 16, 2020 19:57
@thompsongl
Copy link
Contributor

jenkins test this

#2765 strikes again

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do the same with APM / Observability as far as the new logo goes. Replace APM and deprecate, then make a new Observability one.

Sorry, I missed that in my instructions. Your code looks correct though.

@snide
Copy link
Contributor

snide commented Jan 16, 2020

cc @elastic/observability-design and @MichaelMarcialis for visibility that these changes are coming.

@andreadelrio
Copy link
Contributor Author

Updated view with logoObservability instead of logoAPM
image

@andreadelrio andreadelrio requested a review from snide January 16, 2020 21:16
@andreadelrio andreadelrio changed the title Updated logos for Observability and Security and added Workplace Updated logo for Security, added logos for Workplace and Observability Jan 16, 2020
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Double checked the deprecated logos still work and spit out the new icons. Please add a deprecation note to this CL. You can see an example in the 14.0.0 release.

@andreadelrio andreadelrio merged commit 877cb00 into elastic:master Jan 17, 2020
@formgeist
Copy link
Contributor

@snide I would have thought we'd deprecate Logging, Metrics, and Uptime too because we're adding a single Observability solution logo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants