Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiTextArea: converted to Typescript #2695

Merged
merged 3 commits into from
Dec 18, 2019
Merged

EuiTextArea: converted to Typescript #2695

merged 3 commits into from
Dec 18, 2019

Conversation

ffknob
Copy link
Contributor

@ffknob ffknob commented Dec 18, 2019

Summary

Closes #2653

Converted EuiTextArea to Typescript.

Checklist

  • Check against all themes for compatability in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

This was referenced Dec 18, 2019
Closed
Open
chandlerprall
chandlerprall approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, needs to merge changelog from master

@chandlerprall
Copy link
Contributor

jenkins test this

@ffknob
Copy link
Contributor Author

ffknob commented Dec 18, 2019

Changes LGTM, needs to merge changelog from master

done

@chandlerprall chandlerprall merged commit 0b9e6bd into elastic:master Dec 18, 2019
@thompsongl thompsongl mentioned this pull request Dec 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EuiTextArea needs to be converted to TS
4 participants
@ffknob @elasticmachine @chandlerprall @snide