OverlayMask onClick error #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
approved these changes
Jan 4, 2018
There was a problem hiding this comment.
Thanks for the quick fix. This addressed the functional error I saw. No idea if this is the best way to handle it, but it works. I'll leave that to @cjcenizal to review.
cjcenizal
approved these changes
Jan 4, 2018
| @@ -15,6 +15,7 @@ export class EuiOverlayMask extends Component { | |||
| const { | |||
| className, | |||
| children, // eslint-disable-line no-unused-vars | |||
| onClick, | |||
There was a problem hiding this comment.
Can we add this to propTypes?
| @@ -23,7 +24,13 @@ export class EuiOverlayMask extends Component { | |||
| 'euiOverlayMask', | |||
| className | |||
| ); | |||
| if (onClick) { | |||
| this.overlayMaskNode.addEventListener('click', onClick); | |||
There was a problem hiding this comment.
Should we also removeEventListener in componentWillUnmount?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #260
Do not add event handlers to dom element with setAttribute method. Instead, add directly to dom element properties.