Export drag and drop service methods #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompsongl
approved these changes
Sep 25, 2019
|
@thompsongl yeah that's a good call; we don't have a strong precedent here (TBH not even a weak one). They don't need to be discoverable except through the docs, so I'm thinking something like |
|
No strong preference on what the names are. I think the |
|
I'd continue with the |
|
I've updated the method names to |
snide
pushed a commit
to snide/eui
that referenced
this pull request
Oct 10, 2019
* Export move, copy, and reorder drag-and-drop service methods * changelog * Update dnd service method names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2372 by exporting the
copy,move, andreorderdrag-and-drop service methods. I tested by building EUI with this change andrequireing the built package into node, verifying the three methods exist as expected.Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes