Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug where Array.prototype.slice() may have been called on 'undefined' #2369

Merged
merged 3 commits into from
Sep 24, 2019

Conversation

2bit-hack
Copy link
Contributor

@2bit-hack 2bit-hack commented Sep 24, 2019

Summary

Fixes #2362

Fixed bug where Array.prototype.slice() may have been called on 'undefined'

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

Popover fall back slices an undefined value elastic#2362
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thank you @2bit-hack for the contribution!

@chandlerprall
Copy link
Contributor

jenkins test this

@snide snide merged commit 6bc63d1 into elastic:master Sep 24, 2019
@snide snide changed the title Fixed Issue #2362 Fixed bug where Array.prototype.slice() may have been called on 'undefined' Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover fall back slices an undefined value
5 participants