Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow locking of EuiNavDrawer in the expanded state #2247

Merged
merged 16 commits into from
Aug 22, 2019
Merged

Allow locking of EuiNavDrawer in the expanded state #2247

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a22e96e
Added a locked state of EuiNavDrawer
Aug 20, 2019
8c0b566
Auto-collapses at smaller window sizes
Aug 21, 2019
d1a3855
Collapse all when collapse button is clicked
Aug 21, 2019
c129119
Fix passing classname to extra action
Aug 21, 2019
f267226
Allow passing `isLocked` as prop
Aug 21, 2019
a4b44d3
cleanup
Aug 22, 2019
80c5457
Remove default
Aug 22, 2019
b14bbe9
Better labels
Aug 22, 2019
797e931
Fix a11y
Aug 22, 2019
6dcd158
PR fixes
Aug 22, 2019
7d0c5ab
Added is `onIsLockedUpdate` callback
Aug 22, 2019
37ec5c1
cl
Aug 22, 2019
819e51d
Check if callback extists first
Aug 22, 2019
12fd2dc
Role doesn’t work on the expand button itself
Aug 22, 2019
806ff39
Reverse icon and fix aria-label/title
Aug 22, 2019
b17886a
Merge branch 'master' into pin-nav-drawer
cchaos Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/nav_drawer/nav_drawer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,12 +244,12 @@ export class EuiNavDrawer extends Component {
onClick: this.sideNavLockClicked,
iconType: this.state.isLocked ? 'lockOpen' : 'lock',
iconSize: 's',
'aria-label': this.state.isLocked
? sideNavLockCollapsed
: sideNavLockExpanded,
'aria-label': sideNavLockExpanded,
title: this.state.isLocked
? sideNavLockCollapsed
: sideNavLockExpanded,
'aria-checked': this.state.isLocked ? true : false,
role: 'switch',
cchaos marked this conversation as resolved.
Show resolved Hide resolved
}}
onClick={this.collapseButtonClick}
data-test-subj={
Expand Down