toast component jest tests #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
suggested changes
Dec 18, 2017
| }); | ||
| }); | ||
|
|
||
| describe('color', () => { |
There was a problem hiding this comment.
Could you import COLORS from the toast file and loop through each valid value, as in https://github.com/elastic/eui/blob/master/src/components/button/button.test.js#L59 ?
|
I just noticed you might be waiting on me. I'm not sure how to review jest tests since I'm not familiar with them. Someone can pair with me to show me or go ahead merge based on @cjcenizal's approval. |
snide
pushed a commit
to snide/eui
that referenced
this pull request
Dec 21, 2017
* toast jest tests * using test style guide this time * test each color value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.