-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow nested EuiAccordion
s
#2136
Conversation
Co-Authored-By: Chandler Prall <[email protected]>
As far as I can tell, jsdom doesn't allow for setting the full gamut of style properties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Played with some testing ideas, it would be far more work than worth it to test for a regression here.
LGTM; pulled & tested locally
Summary
Fixes #2129, in which an
EuiAccordion
with anEuiAccordion
as a child element does not account for height change when the nested accordion opens.More generally,
EuiAccordion
will now account for more than just nested instances, but anystyle
mutation on children elements.The solution involves abstracting a transition delay/duration service out of
EuiPopover
. These services work withMutationObserver
to sum transition timings and run a callback usingrequestAnimationFrame
Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] This was checked for breaking changes and labeled appropriately- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components