Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nested array in ES Query DSL generation #2133

Merged
merged 3 commits into from
Jul 17, 2019
Merged

Remove nested array in ES Query DSL generation #2133

merged 3 commits into from
Jul 17, 2019

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Jul 17, 2019 •
edited
Loading

Summary

Fixes #2109, removes the nested array in the bool.must.bool.should location.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@chandlerprall chandlerprall requested a review from bevacqua July 17, 2019 17:13
bevacqua
bevacqua approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@bevacqua bevacqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@chandlerprall chandlerprall merged commit a27756d into elastic:master Jul 17, 2019
@chandlerprall chandlerprall deleted the bug/2109-searchbar-query-or-es-dsl branch July 17, 2019 17:55
@thompsongl thompsongl mentioned this pull request Jul 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bevacqua bevacqua bevacqua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in search bar ES query DSL for top level grouped clauses
2 participants
@chandlerprall @bevacqua