Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update popout icon to external link style #2064

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Update popout icon to external link style #2064

merged 2 commits into from
Jun 20, 2019

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Jun 20, 2019 •
edited
Loading

Summary

The current popout icon is used as an external link indicator, but it doesn't look like the typical glyph for that purpose. This PR updates it to look like the traditional external link icon.

Before and after

image

image

Dark mode

image

Sketch pixel grid

💎Note: see the popout-external-link branch in the EUI 2.0 Abstract project for the Sketch version
Screenshot 2019-06-20 13 10 00

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@ryankeairns ryankeairns force-pushed the rk/update-popout-icon branch from a447492 to cd8768d Compare June 20, 2019 17:22
@ryankeairns ryankeairns requested a review from cchaos June 20, 2019 17:23
@ryankeairns ryankeairns marked this pull request as ready for review June 20, 2019 17:23
cchaos
cchaos approved these changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾 🥇

@ryankeairns ryankeairns merged commit bb41f02 into elastic:master Jun 20, 2019
@thompsongl thompsongl mentioned this pull request Jun 25, 2019
Merged
@ryankeairns ryankeairns mentioned this pull request Jun 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryankeairns @cchaos