-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix readonly input groups #2057
Conversation
7c39adc
to
1178843
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/components/form/form_control_layout/_form_control_layout.scss
Outdated
Show resolved
Hide resolved
jenkins test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM
I think that is a different concern which involves: "How do we handle form rows with readOnly inputs" since there is no The lines below show how the example is created which is just passing a eui/src-docs/src/views/form_controls/form_control_layout.js Lines 95 to 97 in 57a866e
I'll leave that for another day 😉 |
While working on #2049, I noticed that we don't currently account for the readonly state when using prepend/append.
This PR, passes the
readOnly
to the EuiFormControlLayout and applies the correct styling. This means also having to explicitly state and use it as a prop for EuiFieldNumber, EuiFieldText, and EuiSelect. These are also the only ones that currently support prepend/append.Before
After
Checklist
[ ] This was checked for breaking changes and labeled appropriately[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components