Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Allow setting of the aria-label of table row selection checkboxes #2043

Merged
merged 27 commits into from
Jun 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
c9a153c
Added ariaLabel customization way for <checkbox> in tables;
PhilippBaranovskiy Jun 14, 2019
79ccf71
Update CHANGELOG
PhilippBaranovskiy Jun 14, 2019
f92b73d
Merge branch 'master' into 1697
PhilippBaranovskiy Jun 17, 2019
38bfbc1
Updated CHANGELOG; Added a note about `ariaLabel` to selection table …
PhilippBaranovskiy Jun 17, 2019
6123738
Merge branch 'master' into 1697
PhilippBaranovskiy Jun 17, 2019
a8d239c
Merge branch 'master' into 1697
PhilippBaranovskiy Jun 18, 2019
76b628c
Replace adding additional prop with passing modifier function
PhilippBaranovskiy Jun 18, 2019
31f838b
Merge branch '1697' of https://github.com/rockfield/eui into 1697
PhilippBaranovskiy Jun 18, 2019
6163584
cleaning up
PhilippBaranovskiy Jun 18, 2019
7b84251
Update src-docs/src/views/tables/selection/selection_section.js
PhilippBaranovskiy Jun 18, 2019
df6c87b
Update src-docs/src/views/tables/selection/selection_section.js
PhilippBaranovskiy Jun 18, 2019
442f86d
Update src-docs/src/views/tables/selection/selection_section.js
PhilippBaranovskiy Jun 18, 2019
8f53c08
Update src-docs/src/views/tables/selection/selection_section.js
PhilippBaranovskiy Jun 18, 2019
d546c8a
Update src-docs/src/views/tables/selection/selection_section.js
PhilippBaranovskiy Jun 18, 2019
4be6c7c
Update src-docs/src/views/tables/selection/selection_section.js
PhilippBaranovskiy Jun 18, 2019
9f2aef6
Update selection_section.js
PhilippBaranovskiy Jun 18, 2019
96ee295
Replace getAriaLabel with using title
PhilippBaranovskiy Jun 18, 2019
e477e2e
Merge branch 'master' into 1697
PhilippBaranovskiy Jun 18, 2019
7338302
Merge branch 'master' into 1697
PhilippBaranovskiy Jun 19, 2019
cfc0f4b
syntax updates
PhilippBaranovskiy Jun 19, 2019
60cdce8
Reverting docs back
PhilippBaranovskiy Jun 19, 2019
faa9c72
Reverting docs back
PhilippBaranovskiy Jun 19, 2019
648a2d8
Reverting docs back
PhilippBaranovskiy Jun 19, 2019
7c9dca9
Updated CHANGELOG
PhilippBaranovskiy Jun 19, 2019
5dce07e
Updated snapshots.
PhilippBaranovskiy Jun 19, 2019
f3d8221
Merge branch 'master' into 1697
PhilippBaranovskiy Jun 24, 2019
3ea689a
review updates
PhilippBaranovskiy Jun 24, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- Pass `EuiSuperSelect`'s `popoverClassName` to the popover's panel ([#2068](https://github.com/elastic/eui/pull/2068))
- Added `editorItemAlignLeft`, `editorItemAlignCenter`, `editorItemRight`, `editorItemAlignTop`, `editorItemAlignMiddle`, `editorItemAlignBottom`, `editorDistributeHorizontal`, `editorDistributeVertical`, `editorPositionTopLeft`, `editorPositionTopRight`, `editorPositionBottomRight`, and `editorPositionBottomLeft` glyphs to `EuiIcon` ([2070](https://github.com/elastic/eui/pull/2070))
- Added missing TS definitions for `EuiRange` ([#2072](https://github.com/elastic/eui/pull/2072))
- Made `aria-label` attribute equal to `title` of the the selection checkbox in table items (for each row) in `EuiBasicTable` ([#2043](https://github.com/elastic/eui/pull/2043))

**Bug fixes**

Expand Down
4 changes: 2 additions & 2 deletions src/components/basic_table/basic_table.js
Original file line number Diff line number Diff line change
Expand Up @@ -868,8 +868,8 @@ export class EuiBasicTable extends Component {
disabled={disabled}
checked={checked}
onChange={onChange}
title={title}
aria-label={selectThisRow}
title={title || selectThisRow}
aria-label={title || selectThisRow}
PhilippBaranovskiy marked this conversation as resolved.
Show resolved Hide resolved
data-test-subj={`checkboxSelectRow-${itemId}`}
/>
)}
Expand Down