Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiInMemoryTable: maintain sort values through external item updates #2035

Merged
merged 2 commits into from
Jun 12, 2019
Merged

EuiInMemoryTable: maintain sort values through external item updates #2035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f732e9
maintain sort values through external item updates
thompsongl Jun 12, 2019
2398dd1
CL; better JS
thompsongl Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
**Bug fixes**

- Fixed `EuiCallOut` header icon alignment ([#2006](https://github.com/elastic/eui/pull/2006))
- Fixed `EuiInMemoryTable` sort value persistence through lifecycle updates ([#2035](https://github.com/elastic/eui/pull/2035))

**Breaking changes**

Expand Down
1 change: 1 addition & 0 deletions src/components/basic_table/in_memory_table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ export class EuiInMemoryTable extends Component {
// We have new items because an external search has completed, so reset pagination state.
return {
prevProps: {
...prevState.prevProps,
items: nextProps.items,
},
pageIndex: 0,
Expand Down