Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiDraggable, EuiDroppable should support the 'data-test-subj' property #1943

Merged
merged 2 commits into from
May 21, 2019
Merged

EuiDraggable, EuiDroppable should support the 'data-test-subj' property #1943

merged 2 commits into from
May 21, 2019

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented May 11, 2019 •
edited
Loading

Fix: #1898

Summary

EuiDraggable, EuiDroppable should support the 'data-test-subj' property

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@alexwizp
Copy link
Contributor Author

@thompsongl @snide please review

@thompsongl thompsongl self-requested a review May 20, 2019 15:40
thompsongl
thompsongl suggested changes May 20, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @alexwizp

Can you add a changelog entry? It should be good to go after that

@alexwizp
Copy link
Contributor Author

@thompsongl sure, done

@thompsongl thompsongl merged commit 85e27b2 into elastic:master May 21, 2019
@thompsongl thompsongl mentioned this pull request Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EuiDraggable, EuiDroppable should support the 'data-test-subj' property
2 participants
@alexwizp @thompsongl