Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes autofill coloring in dark mode #1805

Closed
wants to merge 1 commit into from
Closed

Conversation

snide
Copy link
Contributor

@snide snide commented Apr 6, 2019

Summary

Fixes #827

Applies a similar fix as applied to cloud in https://github.com/elastic/cloud/pull/15106 but uses the correct coloring for the text.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@cchaos
Copy link
Contributor

cchaos commented Apr 8, 2019

This doesn't work for me because the auto-fill background color is too light to see the text:

Screen Shot 2019-04-08 at 11 25 50 AM

@snide
Copy link
Contributor Author

snide commented Apr 18, 2019

Closing this PR so I can find a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autofill too dark in dark mode
2 participants