Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close nav drawer when a link is clicked #1773

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

ryankeairns
Copy link
Contributor

Summary

This change will fix a Kibana issue elastic/kibana#30331 where the expanded nav drawer will remain open if you navigate to the app that you are already viewing. In other words, there is no refresh so the menu doesn't get reloaded to the collapsed state. I noticed this can also happen with the flyout - if it's open and you click on an app icon in the main menu, the flyout stays open. This PR addresses both cases.

Reviewer note

This solution was the outcome of some discussion an initial PR - #1770

Demo

close-drawer

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@ryankeairns ryankeairns marked this pull request as ready for review March 27, 2019 18:16
@cchaos
Copy link
Contributor

cchaos commented Mar 27, 2019

Have you yarn linked it to see if it works in Kibana?

@ryankeairns
Copy link
Contributor Author

@cchaos yep

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I approve 😉

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

@ryankeairns ryankeairns merged commit 4ae760c into elastic:master Mar 27, 2019
Shigawire pushed a commit to Shigawire/eui that referenced this pull request May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants