Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding repositionOnScroll to the EuiPopoverProps type def #1628

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Adding repositionOnScroll to the EuiPopoverProps type def #1628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28c90f0
Adding repositionOnScroll to the EuiPopoverProps type def
kobelb Feb 28, 2019
b45f072
Merge remote-tracking branch 'upstream/master' into eui-popover-repos…
snide Mar 6, 2019
ea786ea
CL added
snide Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Added `repositionOnScroll` property to the `EuiPopoverProps` type definition ([#1628](https://github.com/elastic/eui/pull/1628))
- Added support to `findTestSubject` for an optional `matcher` argument, which defaults to `~=`, enabling it to identify an element based on one of multiple space-separated values within its `data-test-subj` attribute ([#1587](https://github.com/elastic/eui/pull/1587))
- Converted `EuiFlexGrid`, `EuiFlexGroup`, `EuiFlexItem`, `EuiDescriptionList`, `EuiDescriptionListTitle`, and `EuiDescriptionListDescription` to TypeScript ([#1365](https://github.com/elastic/eui/pull/1365))
- Converted `EuiAvatar` to Typescript ([#1654](https://github.com/elastic/eui/pull/1654))
Expand Down
1 change: 1 addition & 0 deletions src/components/popover/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ declare module '@elastic/eui' {
anchorPosition?: PopoverAnchorPosition;
panelClassName?: string;
panelPaddingSize?: PanelPaddingSize;
repositionOnScroll: boolean;
}

export const EuiPopover: FunctionComponent<
Expand Down