-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added displayOnly
prop to EuiFormRow
#1582
Conversation
And updated the form layout page docs with some snippets
da02952
to
ad1c421
Compare
cc @bevacqua |
@chandlerprall Any thoughts on why my changes would cause this in IE11? |
Ugh, I think I found it, stupid VS code auto-imported |
Should |
We ran in circles a bit on this one and ultimately, it all |
+1 to making it optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed code, checked docs and display. All look good.
...and updated the form layout page docs with some snippets.
Basically if you add the
displayOnly
prop, it will add a wrapper around the child and vertically center it.Checklist
[ ] This was checked in dark mode[ ] This was checked for breaking changes and labeled appropriately[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components