Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added displayOnly prop to EuiFormRow #1582

Merged
merged 4 commits into from
Feb 21, 2019
Merged

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Feb 21, 2019

...and updated the form layout page docs with some snippets.


Basically if you add the displayOnly prop, it will add a wrapper around the child and vertically center it.

screen shot 2019-02-21 at 11 21 02 am

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • [ ] This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • [ ] This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • [ ] This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

cchaos added 2 commits February 21, 2019 11:27
And updated the form layout page docs with some snippets
@cchaos cchaos force-pushed the form-row-non-input branch from da02952 to ad1c421 Compare February 21, 2019 16:28
@cchaos
Copy link
Contributor Author

cchaos commented Feb 21, 2019

cc @bevacqua

@cchaos
Copy link
Contributor Author

cchaos commented Feb 21, 2019

@chandlerprall Any thoughts on why my changes would cause this in IE11?

screen shot 2019-02-21 at 11 40 33 am

@cchaos
Copy link
Contributor Author

cchaos commented Feb 21, 2019

Ugh, I think I found it, stupid VS code auto-imported Fragment from the wrong library.

@chandlerprall
Copy link
Contributor

Should EuiFormRow automatically infer from its children if the display-only mode should be on or not, instead of requiring a dev to specify it?

@cchaos
Copy link
Contributor Author

cchaos commented Feb 21, 2019

We ran in circles a bit on this one and ultimately, it all depends, so I'd rather make in an optional/manual prop.

@bevacqua
Copy link
Contributor

+1 to making it optional

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code, checked docs and display. All look good.

@cchaos cchaos merged commit 010b164 into elastic:master Feb 21, 2019
@cchaos cchaos deleted the form-row-non-input branch February 21, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants