Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiFocusTrap; dependency changes #1550

Merged
merged 15 commits into from
Feb 20, 2019
Merged

EuiFocusTrap; dependency changes #1550

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f23532c
WIP: functional EuiFocusTrap
thompsongl Feb 8, 2019
13b8774
Update docs for focus trapping components to show more complex conten…
thompsongl Feb 8, 2019
d7e9c51
basic snapshot tests for focusTrap
thompsongl Feb 8, 2019
36221ff
fix ts definitons and references
thompsongl Feb 11, 2019
95c0d4d
propType descriptions
thompsongl Feb 11, 2019
0c5e80c
focusTrap docs examples
thompsongl Feb 11, 2019
4531e31
Merge branch 'master' into focus-trap
thompsongl Feb 11, 2019
4e74507
#1550 changelog entry
thompsongl Feb 11, 2019
c1ff84d
move lastInterceptedEvent out of state; method comments; simpler disa…
thompsongl Feb 12, 2019
dfc0ae1
better initialFocus logic
thompsongl Feb 12, 2019
47b479e
clean up and add doc descriptions
thompsongl Feb 12, 2019
fc53831
unit tests; refactor intialFocus
thompsongl Feb 13, 2019
b66c6bf
update tests to show before/after expectations
thompsongl Feb 19, 2019
4c6622a
Merge branch 'master' into focus-trap
thompsongl Feb 19, 2019
1661286
changelog release update
thompsongl Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@
- New docs page listing localization tokens ([#1541](https://github.com/elastic/eui/pull/1541))
- Added support for OR group clauses in `EuiQuery` and `EuiSearchBar` ([#1204](https://github.com/elastic/eui/pull/1204))
- Added `customQuickSelectPanels` prop to `EuiSuperDatePicker` ([#1549](https://github.com/elastic/eui/pull/1549))
- Added `EuiFocusTrap` as a wrapper around `react-focus-lock` to enable trapping focus in more cases, including React portals ([#1550](https://github.com/elastic/eui/pull/1550))

**Bug fixes**

- Fixed `EuiSearchBar.Query` match_all query string must be `*` ([#1521](https://github.com/elastic/eui/pull/1521))
- Fixed `EuiSuperDatePicker` crashing with negative relative value ([#1537](https://github.com/elastic/eui/pull/1537))
- Fixed `EuiSuperDatePicker` crashing with invalid start and end prop values ([#1544](https://github.com/elastic/eui/pull/1544))
- Make TSLint issues be warnings, not errors, when running `src-docs` ([#1537](https://github.com/elastic/eui/pull/1537))
- Various fixes related to focus order and focus trapping as they relate to content in React portals ([#1550](https://github.com/elastic/eui/pull/1550))

**Breaking changes**

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
"@types/numeral": "^0.0.25",
"classnames": "^2.2.5",
"core-js": "^2.5.1",
"focus-trap-react": "^3.0.4",
"highlight.js": "^9.12.0",
"html": "^1.0.0",
"keymirror": "^0.1.1",
Expand All @@ -55,6 +54,7 @@
"prop-types": "^15.6.0",
"react-ace": "^5.5.0",
"react-color": "^2.13.8",
"react-focus-lock": "^1.17.7",
"react-input-autosize": "^2.2.1",
"react-is": "~16.3.0",
"react-virtualized": "^9.18.5",
Expand Down
Loading