Feature/more i18n tokens #1504
Merged
Feature/more i18n tokens #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompsongl
reviewed
Jan 31, 2019
| @@ -248,8 +248,8 @@ export class EuiSuperSelect extends Component { | |||
| <p role="alert"> | |||
| <EuiI18n | |||
| token="euiSuperSelect.screenReaderAnnouncement" | |||
| default={`You are in a form selector of {optionsCount} items and must select a single option. | |||
| Use the up and down keys to navigate or escape to close.`} | |||
| default="You are in a form selector of {optionsCount} items and must select a single option. | |||
There was a problem hiding this comment.
This break looks like it was intention before.
There was a problem hiding this comment.
The line break is to prevent the line from exceeding 140 chars (eslint rule). In fact, this change sets the rendered code (https://github.com/elastic/eui/pull/1504/files#diff-b316252fbacff5a6a86691b423c1bbc9) back to what it was before this component was localized (https://github.com/elastic/eui/pull/1450/files#diff-b316252fbacff5a6a86691b423c1bbc9)
thompsongl
reviewed
Jan 31, 2019
src/components/basic_table/__snapshots__/collapsed_item_actions.test.js.snap
Outdated
Show resolved
Hide resolved
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EuiI18nEuiI18nusageChecklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components