EuiSuperDatePicker move EuiDatePopoverButton isOpen state into EuiSuperDatePicker #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug were updating props resets EuiSuperDatePicker
showPrettyDuration. The bug occurs when either start or endEuiSuperDatePickeris open. Clicking on the tabs changes the respective time and callsonChangecausing EuiSuperDatePicker.getDerivedStateFromProps to potentially setshowPrettyDurationto true. This causes theEuiDatePopoverButtonto close unexpectedly because the component is unmounted. The bug is that displaying the pretty duration check only looks atshowPrettyDurationand does not take into account if the date popovers are open.This PR moves the tracking of EuiDatePopoverButton isOpen state into EuiSuperDatePicker so that the pretty duration is only displayed when
showPrettyDurationis true and the date popovers are not open.