Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set type="button" on accordion buttons #1468

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Set type="button" on accordion buttons #1468

merged 1 commit into from
Jan 23, 2019

Conversation

pugnascotia
Copy link
Contributor

Summary

The <button> in <EuiAccordion> doesn’t set a type, so it triggers the submit action in forms.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

snide
snide approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is my fault! Thanks for the PR!

@pugnascotia pugnascotia merged commit d077bd9 into elastic:master Jan 23, 2019
@pugnascotia pugnascotia deleted the set-type-on-accordion-button branch January 23, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pugnascotia @snide