Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New uptime app icon, deprecation warning for charts #1463

Merged
merged 4 commits into from
Jan 23, 2019
Merged

New uptime app icon, deprecation warning for charts #1463

merged 4 commits into from
Jan 23, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Jan 23, 2019 •
edited
Loading

Summary

Coincidentally, both changes are important to the uptime team :)

image

image

image

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@snide snide requested review from cchaos and justinkambic January 23, 2019 00:10
@snide
Copy link
Contributor Author

snide commented Jan 23, 2019

cc @markov00 about the deprecation warning.

justinkambic
justinkambic reviewed Jan 23, 2019
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - everything seems to work fine.

Code mostly LGTM - I had one question.

Also, just checking that we are ok with keeping Series charts (beta) as the text for the route to the charts examples. Should there be a scheduled deprecation warning in the route as well?

Thanks for this, excited to get the icon in ASAP.

src-docs/src/views/icon/apps.js Show resolved Hide resolved
src-docs/src/views/series_chart_bar/bar_example.js Outdated Show resolved Hide resolved
@snide
Copy link
Contributor Author

snide commented Jan 23, 2019

Feedback addressed. Merging after green.

@snide snide merged commit aa634e8 into elastic:master Jan 23, 2019
@snide snide deleted the uptime_and_charts branch January 23, 2019 20:29
@snide snide mentioned this pull request Jan 23, 2019
Open
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic left review comments

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snide @cchaos @justinkambic