Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes header logo width and updates drawer example #1449

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Fixes header logo width and updates drawer example #1449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

- Added Inter UI to the font family stack ([#1402](https://github.com/elastic/eui/pull/1402))
- Changed padding on `EuiHeaderLogo` and updated `EuiNavDrawer` example ([#1448](https://github.com/elastic/eui/pull/1448))
- Updated `EuiNavDrawer` docs example and adjusted `EuiHeaderLogo` padding ([#1449](https://github.com/elastic/eui/pull/1449))

**Bug fixes**

Expand Down
11 changes: 6 additions & 5 deletions src-docs/src/views/nav_drawer/nav_drawer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
EuiHeaderSectionItem,
EuiHeaderSectionItemButton,
EuiHeaderBreadcrumbs,
EuiHeaderLogo,
EuiIcon,
EuiTitle,
EuiNavDrawer,
Expand Down Expand Up @@ -401,11 +402,11 @@ export default class extends Component {

renderLogo() {
return (
<EuiHeaderSectionItemButton
aria-label="Go to home page"
>
<EuiIcon type="logoKibana" href="#" size="l" />
</EuiHeaderSectionItemButton>
<EuiHeaderLogo
iconType="logoKibana"
href="/#/layout/nav-drawer"
aria-label="Goes to home"
/>
);
}

Expand Down
2 changes: 1 addition & 1 deletion src/components/header/_header_logo.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
position: relative;
height: $euiHeaderChildSize;
line-height: $euiHeaderChildSize;
padding: 0 $euiSizeM;
padding: 0 ($euiSizeM + 1px) 0 $euiSizeM;
display: inline-block;
vertical-align: middle;
white-space: nowrap;
Expand Down