Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate className in EuiCodeBlock in fullscreen mode #1422

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Propagate className in EuiCodeBlock in fullscreen mode #1422

merged 1 commit into from
Jan 10, 2019

Conversation

pugnascotia
Copy link
Contributor

@pugnascotia pugnascotia commented Jan 9, 2019 •
edited
Loading

Summary

Propagate className in EuiCodeBlock in fullscreen mode, not just regular mode.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@pugnascotia pugnascotia added the bug label Jan 9, 2019
@pugnascotia pugnascotia requested a review from cchaos January 9, 2019 21:43
cchaos
cchaos approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, ty!

@pugnascotia pugnascotia merged commit b686fc7 into elastic:master Jan 10, 2019
@pugnascotia pugnascotia deleted the code-block-fullscreen-classname branch January 10, 2019 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pugnascotia @cchaos