Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert EuiFlex* and EuiDescriptionList* to typescript #1365

Merged
merged 13 commits into from
Mar 4, 2019
Merged

Convert EuiFlex* and EuiDescriptionList* to typescript #1365

merged 13 commits into from
Mar 4, 2019

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Dec 11, 2018 •
edited
Loading

Summary

  • converted EuiFlexGrid, EuiFlexGroup, EuiFlexItem, EuiDescriptionList, EuiDescriptionListTitle, and EuiDescriptionListDescription to typescript
  • added support for null and `undefined in TS unions to proptypes generator

Checklist

- [ ] This was checked in mobile
- [ ] This was checked in IE11
- [ ] This was checked in dark mode

  • Any props added have proper autodocs
    - [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
    - [ ] This was checked for breaking changes and labeled appropriately
    - [ ] Jest tests were updated or added to match the most common scenarios
    - [ ] This was checked against keyboard-only and screenreader scenarios
    - [ ] This required updates to Framer X components

pugnascotia
pugnascotia suggested changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@pugnascotia pugnascotia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just a few comments and tweaks.

@chandlerprall
Copy link
Contributor Author

Blocked by #1383 for default props.

@chandlerprall chandlerprall changed the title Convert EuiFlex* and EuiDescriptionList* to typescript [blocked] Convert EuiFlex* and EuiDescriptionList* to typescript Dec 18, 2018
@chandlerprall chandlerprall changed the title [blocked] Convert EuiFlex* and EuiDescriptionList* to typescript Convert EuiFlex* and EuiDescriptionList* to typescript Mar 1, 2019
pugnascotia
pugnascotia reviewed Mar 2, 2019
View reviewed changes
src/components/description_list/description_list.tsx Outdated
export type EuiDescriptionListTextStyle = keyof typeof textStylesToClassNameMap;

export interface EuiDescriptionListProps {
listItems?: Array<{ title: ReactNode; description: ReactNode }>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth wrapping the ReactNode uses with NonNullable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, and a great catch.

@chandlerprall chandlerprall merged commit a74e0e0 into elastic:master Mar 4, 2019
@chandlerprall chandlerprall deleted the typescripted-03 branch March 4, 2019 17:46
@snide snide mentioned this pull request Mar 7, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pugnascotia pugnascotia pugnascotia approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chandlerprall @pugnascotia @snide