Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1324: copy ExpressionButton's active state to a focused state #1326

Merged
merged 2 commits into from
Nov 26, 2018
Merged

1324: copy ExpressionButton's active state to a focused state #1326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
693774c
1324: copy ExpressionButton's active state to a focused state
chandlerprall Nov 21, 2018
8467960
changelog
chandlerprall Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- `EuiBasicTable` now converts the `EuiTableRowCell` `header` into `undefined` if it's been provided as a non-string node, hiding the header and preventing the node from being rendered as `[object Object]` on narrow screens ([#1312](https://github.com/elastic/eui/pull/1312))
- Fixed `fullWidth` size of `EuiComboBox`, a regression introduced in `4.7.0` ([#1314](https://github.com/elastic/eui/pull/1314))
- Fixed error when passing empty string as `value` prop for `EuiSuperSelect` ([#1319](https://github.com/elastic/eui/pull/1319))
- `EuiExpressionButton` now shows focus state when user tabs to it ([#1326](https://github.com/elastic/eui/pull/1326))

## [`5.1.0`](https://github.com/elastic/eui/tree/v5.1.0)

Expand Down
4 changes: 4 additions & 0 deletions src/components/expression/_expression.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
border-bottom: $euiBorderEditable;
font-size: $euiFontSize;
cursor: pointer;

&:focus {
border-bottom: solid 2px $expressionColorHighlight;
}
}

.euiExpressionButton__description {
Expand Down