New icons, new sizes for EmptyButton and HRs, un-responsive FlexGroups #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: docs/src/views/query_panel/query_panel.js
Conflicts: docs/src/views/query_panel/query_panel.js
cjcenizal
reviewed
Nov 8, 2017
| @@ -7,6 +7,7 @@ | |||
| .euiPopover { | |||
| display: inline-block; | |||
| position: relative; | |||
| vertical-align: middle; | |||
There was a problem hiding this comment.
Just curious, why was this added?
There was a problem hiding this comment.
Popover is a wrapper for inline elements. Without it, it can cause vertical alignment to get screwy if you have multiple popover items (like pills with popovers) next to each other.
cjcenizal
approved these changes
Nov 8, 2017
cjcenizal
reviewed
Nov 8, 2017
src/components/flex/_flex_item.scss
Outdated
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| // On mobile we force them to stack and act the same. | |||
| @include screenXSmall { | |||
| .euiFlexItem { | |||
| .euiFlexGroup--responsive .euiFlexItem{ | |||
There was a problem hiding this comment.
Minor nit, missing a space before the {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves over a bunch of the generic additions from #109 which we can't pull in yet.
Additions
xssize to our empty buttons (I don't want this applied to regular buttons, which is why I didn't add it there).xsmargin to horizontal rules.EuiFlexGroupwhich disables responsiveness (useful when you use flexgroup more for alignment rather than gridding). Added the prop to a few places that make sense.Adds docs and fixes tests for all of the above.