-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing TS defs and fixing existing def #1240
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5a5cc03
Add missing TS defs and fixing existing def
pugnascotia 9f2dea4
Fix PR number
pugnascotia 24694d2
Add TS definition for EuiFieldNumber
pugnascotia 655d069
Address review comments
pugnascotia b264ed2
Fix another review comment
pugnascotia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
/// <reference path="../../common.d.ts" /> | ||
|
||
import { ReactNode, SFC, InputHTMLAttributes } from 'react'; | ||
|
||
declare module '@elastic/eui' { | ||
|
||
/** | ||
* text field type defs | ||
* | ||
* @see './field_number.js' | ||
*/ | ||
export interface EuiFieldNumberProps { | ||
icon?: string; | ||
isInvalid?: boolean; | ||
fullWidth?: boolean; | ||
isLoading?: boolean; | ||
compressed?: boolean; | ||
prepend?: ReactNode | ReactNode[]; | ||
append?: ReactNode | ReactNode[]; | ||
} | ||
|
||
export const EuiFieldNumber: SFC< | ||
CommonProps & InputHTMLAttributes<HTMLInputElement> & EuiFieldNumberProps | ||
>; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
/// <reference path="../../common.d.ts" /> | ||
|
||
import { SFC, ReactNode, HTMLAttributes } from 'react'; | ||
|
||
declare module '@elastic/eui' { | ||
/** | ||
* @see './form_label.js' | ||
*/ | ||
|
||
export type EuiFormLabelProps = CommonProps & | ||
HTMLAttributes<HTMLLabelElement> & { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
isFocused?: boolean; | ||
isInvalid?: boolean; | ||
}; | ||
|
||
export const EuiFormLabel: SFC<EuiFormLabelProps>; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,10 @@ | ||
/// <reference path="./checkbox/index.d.ts" /> | ||
/// <reference path="./field_text/index.d.ts" /> | ||
/// <reference path="./field_number/index.d.ts" /> | ||
/// <reference path="./field_search/index.d.ts" /> | ||
/// <reference path="./field_text/index.d.ts" /> | ||
/// <reference path="./form_label/index.d.ts" /> | ||
/// <reference path="./form_row/index.d.ts" /> | ||
/// <reference path="./radio/index.d.ts" /> | ||
/// <reference path="./select/index.d.ts" /> | ||
/// <reference path="./switch/index.d.ts" /> | ||
/// <reference path="./text_area/index.d.ts" /> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
/// <reference path="../../common.d.ts" /> | ||
|
||
import {SFC, ReactNode, Ref, OptionHTMLAttributes} from 'react'; | ||
|
||
declare module '@elastic/eui' { | ||
/** | ||
* @see './select.js' | ||
*/ | ||
|
||
export type EuiSelectProps = CommonProps & | ||
OptionHTMLAttributes<HTMLSelectElement> & { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
name?: string; | ||
id?: string; | ||
options: Array<{ text: ReactNode } & OptionHTMLAttributes<HTMLOptionElement>>; | ||
isInvalid?: boolean; | ||
fullWidth?: boolean; | ||
isLoading?: boolean; | ||
hasNoInitialSelection?: boolean; | ||
inputRef?: Ref<HTMLSelectElement>; | ||
compressed?: boolean; | ||
prepend?: ReactNode | ReactNode[]; | ||
append?: ReactNode | ReactNode[]; | ||
}; | ||
|
||
export const EuiSelect: SFC<EuiSelectProps>; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be
IconType
imported fromEuiIcon
'sindex.d.ts