Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorate pagination 'next' and 'previous' buttons with data-test-subj #1182

Merged
merged 3 commits into from
Sep 11, 2018
Merged

Decorate pagination 'next' and 'previous' buttons with data-test-subj #1182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81562a0
Decorate pagination 'next' and 'previous' buttons with data-test-subj
justinkambic Sep 11, 2018
9c17b90
Update CHANGELOG.md with appropriate PR #
justinkambic Sep 11, 2018
9e28e1a
Merge branch 'master' into pagination_decorate-pagination-next-prev-w…
justinkambic Sep 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Decorated `pagination` _next_ and _previous_ buttons with `data-test-subj`. ([#1182](https://github.com/elastic/eui/pull/1182))
- Added `euiFacetButton` and `euiFacetGroup` ([#1167](https://github.com/elastic/eui/pull/1167))
- Added `width` prop to `EuiContextMenu` panels ([#1173](https://github.com/elastic/eui/pull/1173))

Expand Down
4 changes: 4 additions & 0 deletions src/components/basic_table/__snapshots__/in_memory_table.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,7 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
<EuiButtonIcon
aria-label="Previous page"
color="text"
data-test-subj="pagination-button-previous"
disabled={false}
iconSize="m"
iconType="arrowLeft"
Expand All @@ -399,6 +400,7 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
<button
aria-label="Previous page"
className="euiButtonIcon euiButtonIcon--text"
data-test-subj="pagination-button-previous"
disabled={false}
onClick={[Function]}
type="button"
Expand Down Expand Up @@ -532,6 +534,7 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
<EuiButtonIcon
aria-label="Next page"
color="text"
data-test-subj="pagination-button-next"
disabled={true}
iconSize="m"
iconType="arrowRight"
Expand All @@ -541,6 +544,7 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
<button
aria-label="Next page"
className="euiButtonIcon euiButtonIcon--text"
data-test-subj="pagination-button-next"
disabled={true}
onClick={[Function]}
type="button"
Expand Down
2 changes: 2 additions & 0 deletions src/components/pagination/pagination.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export const EuiPagination = ({
disabled={activePage === 0}
color="text"
aria-label="Previous page"
data-test-subj="pagination-button-previous"
/>
);

Expand Down Expand Up @@ -111,6 +112,7 @@ export const EuiPagination = ({
aria-label="Next page"
disabled={activePage === pageCount - 1}
color="text"
data-test-subj="pagination-button-next"
/>
);

Expand Down
4 changes: 4 additions & 0 deletions src/components/table/table_pagination/__snapshots__/table_pagination.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ exports[`EuiTablePagination is rendered 1`] = `
<button
aria-label="Previous page"
class="euiButtonIcon euiButtonIcon--text"
data-test-subj="pagination-button-previous"
type="button"
>
<svg
Expand Down Expand Up @@ -170,6 +171,7 @@ exports[`EuiTablePagination is rendered 1`] = `
<button
aria-label="Next page"
class="euiButtonIcon euiButtonIcon--text"
data-test-subj="pagination-button-next"
type="button"
>
<svg
Expand Down Expand Up @@ -217,6 +219,7 @@ exports[`EuiTablePagination is rendered when hiding the per page options 1`] = `
<button
aria-label="Previous page"
class="euiButtonIcon euiButtonIcon--text"
data-test-subj="pagination-button-previous"
type="button"
>
<svg
Expand Down Expand Up @@ -325,6 +328,7 @@ exports[`EuiTablePagination is rendered when hiding the per page options 1`] = `
<button
aria-label="Next page"
class="euiButtonIcon euiButtonIcon--text"
data-test-subj="pagination-button-next"
type="button"
>
<svg
Expand Down