Small (mostly style) fixes #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
approved these changes
Aug 27, 2018
| &:focus { | ||
| text-decoration: underline; | ||
| outline: solid 3px transparentize($euiLinkColor, .9); | ||
| background-color: transparentize($euiLinkColor, .9); |
There was a problem hiding this comment.
Any reason not to the focus background color here?
$euiFocusBackgroundColor: tintOrShade($euiColorPrimary, 90%, 50%) !default;
There was a problem hiding this comment.
No, I had just copied these from EuiLink
eui/src/components/link/_link.scss
Lines 24 to 27 in b6eed6f
There was a problem hiding this comment.
Should we make all 3 be the same?
There was a problem hiding this comment.
Hmm. I'm guessing there was a good reason we did it with transparency in link.scss so it's likely ok to leave it.
added 3 commits
September 4, 2018 11:11
- Don’t let icon or spinner shrink - Allow empty buttons to truncate - elastic#848 - Allow icon sizes to be passed to EuiButtonIcon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Button Fixes
a. Don’t let icon or spinner shrink
If whatever is containing a button forces the button to shrink, it will properly truncate the text. However, if the button also has an icon, the flex model will force the icon flex-item to shrink as well. This fixes that.
b. Allow empty buttons to truncate
c. Allow icon sizes to be passed to EuiButtonIcon (fixes #848)
Example sizes (in
:focusstate, to see full bounds of button)2. Added focus state to anchor tags within
EuiText3. Fixed alignment and coloring of form control clear button
I noticed in Kibana, the (x) icon was always misaligned, but not in the EUI theme, so this fixes it in both instances.
It also darkens the background so it's a bit more AA compliant and also fixes the dark theme coloring.