Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for indeterminate checkboxes #1108

Merged
merged 6 commits into from
Aug 10, 2018
Merged

Support for indeterminate checkboxes #1108

merged 6 commits into from
Aug 10, 2018

Conversation

bevacqua
Copy link
Contributor

@bevacqua bevacqua commented Aug 10, 2018 •
edited
Loading

Fixes #1107

screen shot 2018-08-10 at 14 46 20

@bevacqua bevacqua requested review from snide and cchaos August 10, 2018 17:58
chandlerprall
chandlerprall suggested changes Aug 10, 2018
View reviewed changes
src/components/form/checkbox/checkbox.js Outdated
this.invalidateIndeterminate(this.props);
}

componentWillReceiveProps(nextProps) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

componentWillReceiveProps is deprecated, use componentDidUpdate instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.

chandlerprall
chandlerprall approved these changes Aug 10, 2018
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

snide
snide reviewed Aug 10, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make the docs cleaner so they're more representative of the state changes, otherwise looks good.

cchaos
cchaos approved these changes Aug 10, 2018
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. You may want to go ahead and add the prop to the TS defs file too.

@cchaos
Copy link
Contributor

cchaos commented Aug 10, 2018

Oh and it needs to be added to EuiCheckbox.propTypes as well

@bevacqua
Copy link
Contributor Author

Done! Also added a default value of false for the prop

@bevacqua bevacqua merged commit 4020c9f into elastic:master Aug 10, 2018
@bevacqua bevacqua deleted the indeterminate-checkboxes branch August 10, 2018 19:16
@chandlerprall chandlerprall mentioned this pull request Jan 23, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@snide snide snide approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bevacqua @cchaos @chandlerprall @snide