Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix width of filter group items #1078

Merged
merged 5 commits into from
Aug 6, 2018
Merged

Fix width of filter group items #1078

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df603db
Fix width of filter group items
Aug 2, 2018
4de22f6
changelog
Aug 2, 2018
a84122d
Min width hack for ie11
snide Aug 6, 2018
9cdb6d2
Merge pull request #9 from snide/ie/minwidthtrick
cchaos Aug 6, 2018
ff841db
Merge branch 'master' into fix-filter-group
cchaos Aug 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
**Bug fixes**

- `EuiMutationObserver`'s `children` prop is no longer marked as required ([#1076](https://github.com/elastic/eui/pull/1076))
- Fixed width of `EuiFilterGroup`'s popover ([#1078](https://github.com/elastic/eui/pull/1078))

## [`3.3.0`](https://github.com/elastic/eui/tree/v3.3.0)

Expand Down
1 change: 0 additions & 1 deletion src-docs/src/views/filter_group/filter_group.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ export default class extends Component {
closePopover={this.closePopover.bind(this)}
panelPaddingSize="none"
withTitle
panelClassName="euiFilterGroup__popoverPanel"
>
<EuiPopoverTitle>
<EuiFieldSearch />
Expand Down
4 changes: 0 additions & 4 deletions src/components/filter_group/_filter_group.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,3 @@
display: block;
}
}

.euiFilterGroup__popoverPanel {
max-width: $euiSize * 20;
}
1 change: 1 addition & 0 deletions src/components/filter_group/_filter_select_item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
@include euiFontSizeS;

padding: $euiSizeXS $euiSizeM;
display: block; // Necessary to make sure it doesn't force the whole popover to be too wide
width: 100%;
text-align: left;
color: $euiTextColor;
Expand Down