[types/toast] add types for EuiToast, EuiGlobalToastList(Item) #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test this |
src/components/toast/index.d.ts
Outdated
| * @see './global_toast_list.js' | ||
| */ | ||
| export interface Toast extends Omit<EuiToastProps, 'id'> { | ||
| id: string | number, |
There was a problem hiding this comment.
what is the reason for allowing number ?
There was a problem hiding this comment.
That's the implementation in Kibana, id is an auto-incrementing number, so I figured since it's supported it should be documented/typed.
There was a problem hiding this comment.
Is it possible/easy to toString that value here? id as a string isn't valid as it is applied to the toast's div, and as we typescript out EUI further this will require a code change to EuiGlobalToastList to correctly support the id attribute as a specific case.
There was a problem hiding this comment.
Yeah, it's all in one location so it won't be hard to fix in Kibana.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds types for the
<EuiToast />,<EuiGlobalToastList />, and<EuiGlobalToastListItem />components.