Fixed regressions from Global Time Picker #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In favor of forcing the consumer to add a `grow` prop. Added a IE message to docs.
added 2 commits
July 23, 2018 16:39
cchaos
changed the title
cchaos
changed the title
|
Ugh, sorry... I'm just gonna stop messing with things. |
snide
reviewed
Jul 23, 2018
|
|
||
| ## [`3.2.0`](https://github.com/elastic/eui/tree/v3.2.0) | ||
|
|
||
| **Note: this release creates a minor regression to the display of `EuiFlexItem`s inside a `column` `EuiFlexGroup`. This is fixed in `master`.** |
There was a problem hiding this comment.
Was this an IE regression only, or at large? If only IE, can you label it. I wouldn't mention master (maybe, ("use a later release instead"), because master will change. Let's just pop a new release 3.2.1 once this goes in.
There was a problem hiding this comment.
No, it wasn't IE only.
There was a problem hiding this comment.
I put in "master" for now, but it should be changed when a release is made to point to the correct release version number as has been the pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed IE flex column fix, in favor of forcing the consumer to add a
growprop.Added a IE message to docs.
AND removed max-width on universal selector of popover children which messed up the popover title.