Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiButtonEmpty] The flush property makes focus background uneven #537

Closed
cchaos opened this issue Mar 19, 2018 · 0 comments · Fixed by #546
Closed

[EuiButtonEmpty] The flush property makes focus background uneven #537

cchaos opened this issue Mar 19, 2018 · 0 comments · Fixed by #546
Assignees
@cchaos

Comments

@cchaos
Copy link
Contributor

cchaos commented Mar 19, 2018

Example:

screen shot 2018-03-19 at 16 28 21 pm

This can be fixed one of two ways:

  1. Use negative margins to pull the element left/right (may act weird depending on it's parent).
  2. Remove padding from both sides, but add margin on opposite side.

I'm thinking the second option.
@cchaos cchaos self-assigned this Mar 19, 2018
cchaos pushed a commit to cchaos/eui that referenced this issue Mar 20, 2018
elastic#537 - Removing padding from *both* sides of EuiEmptyButton …
4a7d819 
…when flush
@cchaos cchaos mentioned this issue Mar 20, 2018
Merged
cchaos pushed a commit to cchaos/eui that referenced this issue Mar 20, 2018
elastic#537 - Removing padding from *both* sides of EuiEmptyButton …
1a1685e 
…when flush
cchaos pushed a commit to cchaos/eui that referenced this issue Mar 22, 2018
elastic#537 - Removing padding from *both* sides of EuiEmptyButton …
731fa7d 
…when flush
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cchaos cchaos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some random fixes cchaos/eui
1 participant
@cchaos