Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Columns resize infinite loop #4364

Closed
lior-fortifieddata opened this issue Dec 8, 2020 · 8 comments
Closed

[EuiDataGrid] Columns resize infinite loop #4364

lior-fortifieddata opened this issue Dec 8, 2020 · 8 comments

Comments

@lior-fortifieddata
Copy link

lior-fortifieddata commented Dec 8, 2020

I'm trying to resolve an issue when resizing a column in EuiDataGrid.
unfortunately I couldn't replicate it in CodeSandBox for more than 1.5 hours,
so I thought it worth asking the team if they know it already
I can share my screen if needed.

you can see the issue below:
when resizing a column, look at the scrollbar at the bottom.

It didnt happen when:

  1. setting initialWidth to the last column
  2. on full screen

scroll2

@j-m
Copy link
Contributor

j-m commented Dec 14, 2020

This happened to me when I put flex items in a cell (#4160), are you doing anything special in RenderCellValue or in leading/trailing columns?

@lior-fortifieddata
Copy link
Author

no, it still happens when commenting the original renderCellValue and trailing / leading columns
for some reason the rendering of the grid is much slower comparing the table (I switched the tables to grids in our portal for using columns resizing), so I must be doing something wrong

image

@lior-fortifieddata
Copy link
Author

lior-fortifieddata commented Dec 14, 2020

ok changing from (originally I had more flex items in this group)
image
where table is the code in the prev comment
to

image

resolved the issue

@chandlerprall
Copy link
Contributor

We've had an internal report of this issue as well, which was not reproducible outside of that instance. Due to the interaction with flex grid - which the virtualization effort removes from data grid - I'm optimistic this is completely resolved in the near future without a workaround.

@lior-fortifieddata
Copy link
Author

lior-fortifieddata commented Dec 14, 2020 via email

@chandlerprall
Copy link
Contributor

We are tracking a few performance issues with EuiDataGrid in #4295 . In-progress work includes virtualization (#4170) and tracking hook calls (#4347).

The main performance lag with EuiDataGrid is DOM creation for each cell, which is very dense compared to the other table components. The virtualization effort helps here, but we'll continue looking for ways to improve that initialization time.

@lior-fortifieddata
Copy link
Author

lior-fortifieddata commented Dec 15, 2020 via email

@cchaos cchaos changed the title EuiDataGrid columns resize infinite loop [EuiDataGrid] Columns resize infinite loop Mar 19, 2021
@cee-chen
Copy link
Member

cee-chen commented Jan 5, 2022

I'm assuming this issue is no longer applicable now that EuiDataGrid is virtualized, so going to go ahead and close this. @lior-fortifieddata, please feel free to reopen this if you're still seeing this issue.

@cee-chen cee-chen closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants