Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiInlineEdit] Creating the EuiInlineEdit Component #3928

Closed
jloleysens opened this issue Aug 17, 2020 · 9 comments · Fixed by #6757
Closed

[EuiInlineEdit] Creating the EuiInlineEdit Component #3928

jloleysens opened this issue Aug 17, 2020 · 9 comments · Fixed by #6757
Assignees

Comments

@jloleysens
Copy link

In the Ingest Node Pipelines plugin in Kibana (Home > Stack Management > Ingest Node Pipelines) there is a component that provides an "in-place" or "inline" text editing UX. Specifically when editing a pipeline (see gif).

This component/behaviour seems well suited to living in EUI and should have an accompanying style guide explaining where it can be useful.

For instance, a capability like this can help make certain editing experiences more streamlined while not cluttering up the UI with text boxes or sending users through multiple clicks to edit a value. This is different to the more typical flow of see a thing, click to expand the details, then click edit. Only then is the user presented with a text field to enter or edit a value.

At an implementation level, this could be part of the existing text field component and simply be a prop that gets set to adapt the appearance.

Gif

Aug-17-2020 11-15-21

@elizabetdev elizabetdev self-assigned this Sep 18, 2020
@cchaos cchaos added the ⚠️ needs spec Should be groomed by the EUI team every week to ensure a spec is added label Sep 20, 2020
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@myasonik
Copy link
Contributor

++ If Elastic products are going to have this type of pattern, would love to see it handled in EUI because I worry about individual implementation a11y

@hbharding
Copy link
Contributor

hbharding commented Aug 2, 2022

I noticed we do this in a few places in Observability. It looked a little off to me, so I decided to mock up a concept of what this could look like. Perhaps we could have an editable wrapper like this for EuiTitle and EuiText.

GIF
Kapture 2022-08-02 at 11 04 46

Figma
image

Explortatory view GIF

Kapture 2022-08-02 at 11 42 06

@elizabetdev
Copy link
Contributor

There is also a request for in-place title editing in tabs: #6066 (comment)

Something to note that isn't completely reflected in this early design is that we'd like to have as much of the behaviour inline as possible. As in, the naming / editing of tabs, rearranging, deleting etc.

@ThomThomson
Copy link
Contributor

This is such a cool component! Another use case that could be helpful for this is allowing the user to change the title of a visualization when editing it in Lens. The breadcrumb itself could become editable using this component.

elastic/kibana#140637 (comment)

@MichaelMarcialis
Copy link
Contributor

Hey, gang! Is this inline editing component something that's been prioritized for development by the EUI team? Or is it still in the spec definition/discussion phase? I could swear that I heard somewhere that this was being worked on, I could be misremembering. This proposed component came to mind in discussions I was in with the visualization and dashboard teams regarding whether we could perform inline editing on things like visualization titles, legend labels, etc.

@elizabetdev
Copy link
Contributor

Hi @MichaelMarcialis,

Is this inline editing component something that's been prioritized for development by the EUI team?

It is currently in progress as you can see here: https://github.com/orgs/elastic/projects/1079/views/3

@breehall is the developer working on this, but she's on PTO. She was working with Henry. As soon as she's back we can see what is the current status.

@elizabetdev
Copy link
Contributor

@daveyholler do you have any update on this?

@breehall breehall changed the title [Discuss] "In-place" text editing UX [EuiInlineEdit] Creating the EuiInlineEdit Component Jan 19, 2023
@JasonStoltz JasonStoltz changed the title [EuiInlineEdit] Creating the EuiInlineEdit Component [Meta][EuiInlineEdit] Creating the EuiInlineEdit Component Apr 3, 2023
@JasonStoltz JasonStoltz added roadmap and removed assign:designer ⚠️ needs spec Should be groomed by the EUI team every week to ensure a spec is added labels Apr 3, 2023
@JasonStoltz JasonStoltz changed the title [Meta][EuiInlineEdit] Creating the EuiInlineEdit Component [EuiInlineEdit] Creating the EuiInlineEdit Component Apr 3, 2023
@JasonStoltz JasonStoltz removed the meta label Apr 3, 2023
@breehall
Copy link
Contributor

Development is rapidly coming to a close on EuiInlineEdit. Here are a few things that should happen after Inline Edit has merged into main.

✨ What's Up Next?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants