Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures every id attribute value is unique on ace_editor #2414

Closed
bhavyarm opened this issue Oct 10, 2019 · 2 comments · Fixed by #2411
Closed

Ensures every id attribute value is unique on ace_editor #2414

bhavyarm opened this issue Oct 10, 2019 · 2 comments · Fixed by #2411
Labels
accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility bug

Comments

@bhavyarm
Copy link
Contributor

While adding management accessibility test here - we got this violation: elastic/kibana#43584

VIOLATION
[duplicate-id]: Ensures every id attribute value is unique
Help: https://dequeuniversity.com/rules/axe/3.3/duplicate-id?application=axeAPI
Elements:
- #\37 x57vxkj > .euiCodeEditorWrapper[data-test-subj="codeEditorContainer"] > .ace_editor.ace-tm

cc @myasonik

Screen Shot 2019-10-10 at 5 19 19 PM

Screen Shot 2019-10-10 at 5 19 30 PM
@bhavyarm bhavyarm added bug accessibility accessibility - WCAG A Level A WCAG Accessibility Criteria labels Oct 10, 2019
@snide
Copy link
Contributor

snide commented Oct 10, 2019

#2411 Addresses this

@bhavyarm
Copy link
Contributor Author

++ having an issue to track our ignore rule for components in automated testing

@myasonik myasonik mentioned this issue Oct 11, 2019
Merged
5 tasks
snide pushed a commit that referenced this issue Oct 11, 2019
@snide
Fixes several a11y issues manifesting in Kibana (#2411)
f475ce9 
Fixes several of misc a11y issues showing up in Kibana:
- Poor labeling in `EuiSuperDatePicker` ([Kibana issue 38794](elastic/kibana#38794)) (this kind of snowballed into improving several things in the vicinity)
- Fixes #2416: `EuiFormRow`s that render fields that also render a label end up rendering multiple labels for an input which breaks many assistive tech (this issue was found during the in progress Kibana rollout of automated a11y testing ([Kibana issue 43584](elastic/kibana#43584) )
- Fixes #2414: `EuiCodeEditor`s would render with the same ID which breaks many assistive tech (this issue was found during the in progress Kibana rollout of automated a11y testing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes several a11y issues manifesting in Kibana myasonik/eui
2 participants
@snide @bhavyarm