Skip to content

Commit

Permalink
extra props on EuiInMemoryTable and EuiBasicTable (#836)
Browse files Browse the repository at this point in the history
* pass extra props from EuiInMemoryTable to EuiBasicTable

* changelog
  • Loading branch information
chandlerprall authored May 17, 2018
1 parent f7beb61 commit fcc305a
Show file tree
Hide file tree
Showing 5 changed files with 151 additions and 3 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## [`master`](https://github.com/elastic/eui/tree/master)

**Bug fixes**
- `EuiInMemoryTable` and `EuiBasicTable` now pass unknown props through to their child ([#836](https://github.com/elastic/eui/pull/836))

**Breaking changes**

- Move `EuiBasicTable`'s `itemId` prop from `selection` to a top-level property ([#830](https://github.com/elastic/eui/pull/830))
Expand Down
32 changes: 32 additions & 0 deletions src/components/basic_table/__snapshots__/basic_table.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

exports[`EuiBasicTable basic - empty - custom message 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile />
Expand Down Expand Up @@ -37,7 +39,9 @@ exports[`EuiBasicTable basic - empty - custom message 1`] = `

exports[`EuiBasicTable basic - empty - custom message as node 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile />
Expand Down Expand Up @@ -80,7 +84,9 @@ exports[`EuiBasicTable basic - empty - custom message as node 1`] = `

exports[`EuiBasicTable basic - empty 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile />
Expand Down Expand Up @@ -115,7 +121,9 @@ exports[`EuiBasicTable basic - empty 1`] = `

exports[`EuiBasicTable basic - with items 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile />
Expand Down Expand Up @@ -276,7 +284,9 @@ exports[`EuiBasicTable itemIdToExpandedRowMap renders an expanded row 1`] = `

exports[`EuiBasicTable with pagination - 2nd page 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile />
Expand Down Expand Up @@ -344,7 +354,9 @@ exports[`EuiBasicTable with pagination - 2nd page 1`] = `

exports[`EuiBasicTable with pagination 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile />
Expand Down Expand Up @@ -428,7 +440,9 @@ exports[`EuiBasicTable with pagination 1`] = `

exports[`EuiBasicTable with pagination and error 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile />
Expand Down Expand Up @@ -469,7 +483,9 @@ exports[`EuiBasicTable with pagination and error 1`] = `

exports[`EuiBasicTable with pagination and selection 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile />
Expand Down Expand Up @@ -611,7 +627,9 @@ exports[`EuiBasicTable with pagination and selection 1`] = `

exports[`EuiBasicTable with pagination, selection and sorting 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile>
Expand Down Expand Up @@ -770,7 +788,9 @@ exports[`EuiBasicTable with pagination, selection and sorting 1`] = `

exports[`EuiBasicTable with pagination, selection, sorting and a single record action 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile>
Expand Down Expand Up @@ -1020,7 +1040,9 @@ exports[`EuiBasicTable with pagination, selection, sorting and a single record a

exports[`EuiBasicTable with pagination, selection, sorting and column dataType 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile>
Expand Down Expand Up @@ -1179,7 +1201,9 @@ exports[`EuiBasicTable with pagination, selection, sorting and column dataType 1

exports[`EuiBasicTable with pagination, selection, sorting and column renderer 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile>
Expand Down Expand Up @@ -1338,7 +1362,9 @@ exports[`EuiBasicTable with pagination, selection, sorting and column renderer 1

exports[`EuiBasicTable with pagination, selection, sorting and multiple record actions 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile>
Expand Down Expand Up @@ -1582,7 +1608,9 @@ exports[`EuiBasicTable with pagination, selection, sorting and multiple record a

exports[`EuiBasicTable with pagination, selection, sorting, column renderer and column dataType 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile>
Expand Down Expand Up @@ -1741,7 +1769,9 @@ exports[`EuiBasicTable with pagination, selection, sorting, column renderer and

exports[`EuiBasicTable with sortable columns and sorting disabled 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile />
Expand Down Expand Up @@ -1814,7 +1844,9 @@ exports[`EuiBasicTable with sortable columns and sorting disabled 1`] = `

exports[`EuiBasicTable with sorting 1`] = `
<div
aria-label="aria-label"
className="euiBasicTable testClass1 testClass2"
data-test-subj="test subject string"
>
<div>
<EuiTableHeaderMobile>
Expand Down
Loading

0 comments on commit fcc305a

Please sign in to comment.