Skip to content

Commit

Permalink
Fix missing cell popover opacity transition
Browse files Browse the repository at this point in the history
+ flash of content on initial load for cell contents being limited by the new inline max-width
  • Loading branch information
cee-chen committed Nov 8, 2023
1 parent 1ecfb1b commit f64bb1a
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions src/components/datagrid/_data_grid_data_row.scss
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@
// since we don't use the popover arrow in any case for cell popovers
filter: none;
@include euiBottomShadow; // TODO: Convert to euiShadowMedium() in Emotion

// For some reason, the normal popover opacity transition doesn't work for datagrid popovers
// so we'll force it via an animation. If we don't, cells constrained by the inline max-width
// style that we set will see a flash of unwanted content before repositioning
animation-duration: $euiAnimSpeedNormal;
animation-name: euiDataGridCellPopover;
}

.euiDataGridRowCell--controlColumn .euiDataGridRowCell__content {
Expand Down Expand Up @@ -253,3 +259,12 @@
transform: scaleY(1);
}
}

@keyframes euiDataGridCellPopover {
from {
opacity: 0;
}
to {
opacity: 1;
}
}

0 comments on commit f64bb1a

Please sign in to comment.