Skip to content

Commit

Permalink
Exclude custom_typings from eui.d.ts (#1395)
Browse files Browse the repository at this point in the history
Closes #1388. The `src/custom_typings` directory contains some TS definitions that allows TS files to import images without complaint. However, these definitions were being included in `eui.d.ts`, which meant downstream projects couldn't include their own mechanisms for importing images. The fix is to exclude `custom_typings` from `eui.d.ts`
  • Loading branch information
pugnascotia authored Dec 21, 2018
1 parent eb36fc9 commit c0cda96
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Added `EuiSuperDatePicker` component ([#1351](https://github.com/elastic/eui/pull/1351))
- Fixed up styles for `EuiSuperDatePicker` ([#1389](https://github.com/elastic/eui/pull/1389))
- Altered a few icons and added more: `crossInACircleFilled`, `editorRedo`, `editorUndo`, `grabHorizontal`, `minusInCircleFilled`, `plusInCircleFilled`, `sortable`, `starEmptySpace`, `starFilledSpace`, `starFilled`, `starMinusEmpty`, `starMinusFilled`, `starPlusEmpty`, `pinFilled` ([#1374](https://github.com/elastic/eui/pull/1374))
- Exclude `custom_typings` from `eui.d.ts` ([#1395](https://github.com/elastic/eui/pull/1395))

**Bug fixes**

Expand Down
1 change: 1 addition & 0 deletions scripts/dtsgenerator.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const generator = dtsGenerator({
name: '@elastic/eui',
project: baseDir,
out: 'eui.d.ts',
exclude: ['node_modules/**/*.d.ts', 'src/custom_typings/**/*.d.ts'],
resolveModuleId(params) {
if (path.basename(params.currentModuleId) === 'index') {
// this module is exporting from an `index(.d)?.ts` file, declare its exports straight to @elastic/eui module
Expand Down

0 comments on commit c0cda96

Please sign in to comment.