Eui prefers FunctionComponent over FC

elastic · Mar 1, 2020 · a496fcc · a496fcc
1 parent 81bd676
commit a496fcc
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 13 deletions.
diff --git a/src/components/date_picker/date_picker_range.tsx b/src/components/date_picker/date_picker_range.tsx
@@ -1,4 +1,9 @@
-import React, { cloneElement, Fragment, FC, ReactElement } from 'react';
+import React, {
+  cloneElement,
+  Fragment,
+  FunctionComponent,
+  ReactElement,
+} from 'react';
 import classNames from 'classnames';
 
 import { EuiText } from '../text';
@@ -30,7 +35,7 @@ export type EuiDatePickerRangeProps = CommonProps & {
   startDateControl: ReactElement<EuiDatePickerProps>;
 };
 
-export const EuiDatePickerRange: FC<EuiDatePickerRangeProps> = ({
+export const EuiDatePickerRange: FunctionComponent<EuiDatePickerRangeProps> = ({
   children,
   className,
   startDateControl,

diff --git a/src/components/date_picker/super_date_picker/date_popover/date_popover_button.tsx b/src/components/date_picker/super_date_picker/date_popover/date_popover_button.tsx
@@ -1,4 +1,8 @@
-import React, { FC, ButtonHTMLAttributes, MouseEventHandler } from 'react';
+import React, {
+  FunctionComponent,
+  ButtonHTMLAttributes,
+  MouseEventHandler,
+} from 'react';
 import classNames from 'classnames';
 
 import { EuiPopover, EuiPopoverProps } from '../../../popover';
@@ -28,7 +32,9 @@ export interface EuiDatePopoverButtonProps {
   value: string;
 }
 
-export const EuiDatePopoverButton: FC<EuiDatePopoverButtonProps> = props => {
+export const EuiDatePopoverButton: FunctionComponent<
+  EuiDatePopoverButtonProps
+> = props => {
   const {
     position,
     isDisabled,

diff --git a/src/components/date_picker/super_date_picker/date_popover/date_popover_content.tsx b/src/components/date_picker/super_date_picker/date_popover/date_popover_content.tsx
@@ -1,4 +1,4 @@
-import React, { FC } from 'react';
+import React, { FunctionComponent } from 'react';
 
 import { EuiTabbedContent, EuiTabbedContentProps } from '../../../tabs';
 import { EuiText } from '../../../text';
@@ -26,7 +26,9 @@ export interface EuiDatePopoverContentProps {
   position: 'start' | 'end';
 }
 
-export const EuiDatePopoverContent: FC<EuiDatePopoverContentProps> = ({
+export const EuiDatePopoverContent: FunctionComponent<
+  EuiDatePopoverContentProps
+> = ({
   value,
   roundUp = false,
   onChange,

diff --git a/...mponents/date_picker/super_date_picker/quick_select_popover/commonly_used_time_ranges.tsx b/...mponents/date_picker/super_date_picker/quick_select_popover/commonly_used_time_ranges.tsx
@@ -1,4 +1,4 @@
-import React, { FC } from 'react';
+import React, { FunctionComponent } from 'react';
 import { EuiI18n } from '../../../i18n';
 import { EuiFlexGrid, EuiFlexItem } from '../../../flex';
 import { EuiTitle } from '../../../title';
@@ -14,10 +14,9 @@ export interface EuiCommonlyUsedTimeRangesProps {
   commonlyUsedRanges: DurationRange[];
 }
 
-export const EuiCommonlyUsedTimeRanges: FC<EuiCommonlyUsedTimeRangesProps> = ({
-  applyTime,
-  commonlyUsedRanges,
-}) => {
+export const EuiCommonlyUsedTimeRanges: FunctionComponent<
+  EuiCommonlyUsedTimeRangesProps
+> = ({ applyTime, commonlyUsedRanges }) => {
   const legendId = generateId();
   const links = commonlyUsedRanges.map(({ start, end, label }) => {
     const applyCommonlyUsed = () => {

diff --git a/src/components/date_picker/super_date_picker/quick_select_popover/recently_used.tsx b/src/components/date_picker/super_date_picker/quick_select_popover/recently_used.tsx
@@ -1,4 +1,4 @@
-import React, { Fragment, FC } from 'react';
+import React, { Fragment, FunctionComponent } from 'react';
 import { prettyDuration } from '../pretty_duration';
 
 import { EuiFlexGroup, EuiFlexItem } from '../../../flex';
@@ -16,7 +16,7 @@ export interface EuiRecentlyUsedProps {
   recentlyUsedRanges?: DurationRange[];
 }
 
-export const EuiRecentlyUsed: FC<EuiRecentlyUsedProps> = ({
+export const EuiRecentlyUsed: FunctionComponent<EuiRecentlyUsedProps> = ({
   applyTime,
   commonlyUsedRanges,
   dateFormat,