Skip to content

Commit

Permalink
[Accessibility] EuiBottomBar refers to the end of document. (#1727)
Browse files Browse the repository at this point in the history
Change the text to reference the end of the document, not the position.
  • Loading branch information
theodesp authored and snide committed Mar 15, 2019
1 parent 637e392 commit 90240a0
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
**Bug fixes**

- Adds missing type and fixes closure-scope problem for `SuperDatePicker`'s `onRefresh` callback ([#1732](https://github.com/elastic/eui/pull/1732))
- Changed `EuiBottomBar` to refer to the end of document ([#1727](https://github.com/elastic/eui/pull/1727))

## [`9.4.0`](https://github.com/elastic/eui/tree/v9.4.0)

Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/i18ntokens.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
},
{
"token": "euiBottomBar.screenReaderAnnouncement",
"defString": "There is a new menu opening with page level controls at the bottom of the document.",
"defString": "There is a new menu opening with page level controls at the end of the document.",
"highlighting": "string",
"loc": {
"start": {
Expand Down
10 changes: 5 additions & 5 deletions src/components/bottom_bar/__snapshots__/bottom_bar.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Array [
aria-live="assertive"
class="euiScreenReaderOnly"
>
There is a new menu opening with page level controls at the bottom of the document.
There is a new menu opening with page level controls at the end of the document.
</p>,
<div
aria-label="aria-label"
Expand All @@ -24,7 +24,7 @@ Array [
aria-live="assertive"
class="euiScreenReaderOnly"
>
There is a new menu opening with page level controls at the bottom of the document.
There is a new menu opening with page level controls at the end of the document.
</p>,
<div
class="euiBottomBar euiBottomBar--paddingLarge"
Expand All @@ -38,7 +38,7 @@ Array [
aria-live="assertive"
class="euiScreenReaderOnly"
>
There is a new menu opening with page level controls at the bottom of the document.
There is a new menu opening with page level controls at the end of the document.
</p>,
<div
class="euiBottomBar euiBottomBar--paddingMedium"
Expand All @@ -52,7 +52,7 @@ Array [
aria-live="assertive"
class="euiScreenReaderOnly"
>
There is a new menu opening with page level controls at the bottom of the document.
There is a new menu opening with page level controls at the end of the document.
</p>,
<div
class="euiBottomBar"
Expand All @@ -66,7 +66,7 @@ Array [
aria-live="assertive"
class="euiScreenReaderOnly"
>
There is a new menu opening with page level controls at the bottom of the document.
There is a new menu opening with page level controls at the end of the document.
</p>,
<div
class="euiBottomBar euiBottomBar--paddingSmall"
Expand Down
2 changes: 1 addition & 1 deletion src/components/bottom_bar/bottom_bar.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class EuiBottomBar extends Component {
<p aria-live="assertive">
<EuiI18n
token="euiBottomBar.screenReaderAnnouncement"
default="There is a new menu opening with page level controls at the bottom of the document."
default="There is a new menu opening with page level controls at the end of the document."
/>
</p>
</EuiScreenReaderOnly>
Expand Down

0 comments on commit 90240a0

Please sign in to comment.